-
Notifications
You must be signed in to change notification settings - Fork 91
fix: change bg color and text color for contrast checker pass #4047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-23.x
Are you sure you want to change the base?
fix: change bg color and text color for contrast checker pass #4047
Conversation
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4047 +/- ##
=============================================
Coverage 94.39% 94.39%
=============================================
Files 242 242
Lines 4296 4296
Branches 981 1021 +40
=============================================
Hits 4055 4055
+ Misses 237 233 -4
- Partials 4 8 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Container/README.md
Outdated
|
|
||
| ```jsx live | ||
| <div style={{ overflowX: 'auto' }}> | ||
| <div style={{ width: '1500px', border: 'solid 3px red' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the colors consistent, we could change border color also
| <div style={{ width: '1500px', border: 'solid 3px red' }}> | |
| <div style={{ width: '1500px', border: 'solid 3px var(--pgn-color-danger-700)' }}> |
|
Please add this issue to the PR description - #2933 |
e53d041 to
dbbc4e7
Compare
Description
The text and background colors used in the Container component example meet all relevant accessibility contrast requirements (WCAG AA or higher).
Changes
Before
After
Contrast checker result