Skip to content

Conversation

@MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Dec 15, 2025

Description

This PR:

  • Updates how the content libraries' permissions work to reflect the addition of openedx-authz.
  • Adds openedx-authz information.

Detailed:

  • Update the explicit roles table information regarding content libraries.
  • Update the oep-66 to add openedx-authz and update the content library part.
  • I removed the explicit roles diagram because it is difficult to maintain, and it'll probably change with each release.
  • I didn't change the bridgekeeper or other best practices to use the new authz system because the openedx-authz doesn't support custom roles and permissions yet.

How to test

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 15, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu!

This repository is currently maintained by @sarina.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 15, 2025
@MaferMazu MaferMazu linked an issue Dec 15, 2025 that may be closed by this pull request
@MaferMazu MaferMazu requested a review from sarina December 15, 2025 16:17
@MaferMazu MaferMazu moved this to Ready for review in RBAC AuthZ Board Dec 15, 2025
@bmtcril
Copy link
Contributor

bmtcril commented Dec 15, 2025

I haven't had a chance to read through everything yet, but don't forget to change the "last modified" date and to add yourself to the authors list. 😃

Copy link

@rodmgwgu rodmgwgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple of comments

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaferMazu
Copy link
Contributor Author

@bmtcril @rodmgwgu @sarina, this is ready for another round of review. Thanks in advance.

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@itsjeyd itsjeyd moved this from Needs Triage to In Eng Review in Contributions Dec 18, 2025
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Dec 18, 2025
@MaferMazu MaferMazu merged commit 328694e into openedx:master Dec 18, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in RBAC AuthZ Board Dec 18, 2025
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Update OEP-66 documentation

6 participants