feat: add authz permission for certificates#38190
feat: add authz permission for certificates#38190dwong2708 wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@dwong2708 Please fill in the testing instructions in the description |
rodmgwgu
left a comment
There was a problem hiding this comment.
Just a couple of small details, thanks!
| request.user, | ||
| COURSES_MANAGE_CERTIFICATES.identifier, | ||
| course_key, | ||
| LegacyAuthoringPermission.READ |
There was a problem hiding this comment.
I think to keep the previous behavior this should be LegacyAuthoringPermission.WRITE (was has_studio_write_access)
| from common.djangoapps.student.tests.factories import UserFactory | ||
|
|
||
|
|
||
| class AuthzTestMixin: |
There was a problem hiding this comment.
Didn't we already have a Mixin for this? (from your previous PR)
Resolves: openedx/openedx-authz#199
Description
This PR introduces a new authorization permission for certificates and integrates it into the certificates endpoint behind a feature flag.
The goal is to align certificate access with the new AuthZ framework while maintaining backward compatibility through the flag.
Changes
- Validate access for course staff
- Validate access for course editor (non-staff)
Endpoint Affected
GET /api/contentstore/v1/certificates/<course_id>/Now enforces courses.manage_certificates when the feature flag is enabled
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
Verawood