Feat/course home tab carousel #638

IvanStepanok · 2025-09-08T06:47:22Z

Portrait

portrait.mov

Landscape

landscape.mov

iPad

iPad.mov

Dark Theme

carousel in progress, first carousel slide finished

* feat: course progress tab without colors and analytics * feat: add new value assignmentColors to response * fix: grade completion calculation * fix: change NO_GRADED_ASSIGNMENTS localization * fix: update tests * feat: address feedback * fix: tests * feat: add assignment colors * feat: update accessibility strings * fix: change grade titile * feat: add more accessibility * fix: totalProblems calculation * feat: update grade points value * fix: update earnedPoints * feat: add bindings to subviews * feat: add default assignment colors * fix: remove development team * fix: address feedback * feat: update default colors

* feat: add content tab * feat: add segmented controll * feat: Implement AllContentView and section progress UI * feat: add Videos screen * feat: autoscroll to first non watched video * feat: Add toggle to show/hide completed videos in course view Introduces a toggle in the course progress view to show or hide completed videos. Updates VideoSectionView and VideosContentView to filter visible videos based on the toggle state. Adds new localization strings for the toggle and updates progress display to show watched videos. Refactors related UI and logic for improved user experience. * fix: navigation to selected video * feat: add local video thumbnail generation fallback * fix: load video thumbnail in offline mode * feat: save and show local video progress remove old video tab * feat: add course progress calculation and update views * feat: add course progress endpoint * feat: work in progress * feat: small fixes * feat: add pointer * feat: add routing * feat: add short_label value * feat: add short_label to cells * feat: update clearLabel logic * feat: refactor assignment status handling and UI logic * feat: add localizations * feat: refactor completed assignments toggle in progress section * feat: add assignment color support to grading policy * feat: update local progress applying to video * feat: load current progress for videos * feat: refactor assignment status logic and fix status usage * fix: address feedback * feat: before refactoring * fix: refactoring * feat: add grading policy button * feat: add accessibility * feat: update tests * feat: update view completed button logic * feat: refactoring * feat: address feedback * feat: address feedback * feat: add course progress offline * fix: offline loading * feat: add binding logic for videos * fix: move logic to vm * fix: update assignments to use bindings * fix: address feedback * fix: remove published from realDownloadedFilesSize * feat: move thumbnail logic to external service * fix: archive issue * fix: address feedback * fix: address feedback * feat: add dividers to assignments content view * feat: update analytics * feat: address feedback * fix: all tab address feedback * fix: update download icon color * feat: hide zero points * feat: update default colors * fix: address feedback * feat: update accessibility on videos tab * feat: add titles to videos * fix: completed sections order * feat: add section name to AssignmentDetailCard * fix: merge conflicts * fix: update xcode tests version

openedx-webhooks · 2025-09-08T06:47:27Z

Thanks for the pull request, @IvanStepanok!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

edschema · 2025-09-23T05:25:11Z

This looks great @IvanStepanok
For the videos tab, to make it consistent with the Android implementation, can we remove the section name under the video?

For the Video card: if the video has not been started, the text should read "Next Video". Continue watching is for videos that are started but not yet finished.

Thanks!

Demian-Yushyn · 2025-09-23T07:04:18Z

@edschema hi!

Section name was removed
I added "Next Video" text for this case, now it works as supposed

* fix: address feedback * chore: update oexfoundation library

…ab-carousel

RawanMatar89

LGTM 👍🏻

RawanMatar89 · 2025-10-21T10:39:56Z

Course/Course/Domain/Model/CourseProgressDetails.swift

        self.verificationData = verificationData
    }

+    public func getAssignmentProgressForGrades1(for assignmentType: String) -> AssignmentProgressData {


I can't see so much differences between "getAssignmentProgressForGrades1" and "getAssignmentProgress" why we have two ?

RawanMatar89 · 2025-10-21T10:52:02Z

Core/Core/View/Base/UnitButtonView.swift

    case continueLesson
    case nextSection
    case custom(String)
+    case continueLessonCustom(String)


maybe "customContinueLesson" will be better

RawanMatar89 · 2025-10-21T11:04:22Z

Course/Course/Presentation/Container/CourseContainerViewModel.swift

    }
-
+
+    func chapterProgressDeep(for chapter: CourseChapter) -> Double {


I think "chapterCompletionProgress" is more discriptive than "chapterProgressDeep"

RawanMatar89 · 2025-10-21T11:07:26Z

Course/Course/Presentation/Container/CourseContainerViewModel.swift

+        return max(0.0, min(1.0, averageProgress))
+    }
+
+    func chapterProgressDeepPercents(for chapter: CourseChapter) -> Int {


here also
I think "chapterCompletionPercentProgress" is more discriptive than "chapterProgressDeepPercents"
Or even we should have one function with parameter to return as percent or just the progress

Demian-Yushyn · 2025-10-21T12:23:20Z

@RawanMatar89 thanks for your review! All issues are fixed now.

RawanMatar89

LGTM 👏🏻

codecov · 2025-10-22T08:01:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@a43480c). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff            @@
##             develop   #638   +/-   ##
========================================
  Coverage           ?      0           
========================================
  Files              ?      0           
  Lines              ?      0           
  Branches           ?      0           
========================================
  Hits               ?      0           
  Misses             ?      0           
  Partials           ?      0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

IvanStepanok and others added 24 commits June 24, 2025 13:08

feat: course progress tab without colors and analytics

34fdd63

feat: add new value assignmentColors to response

f0fdcce

fix: grade completion calculation

7aea392

fix: change NO_GRADED_ASSIGNMENTS localization

85ea113

fix: update tests

f7ddb9c

feat: address feedback

8cbf5db

fix: tests

844cfd7

feat: course home tab

315c334

carousel in progress, first carousel slide finished

fix: adjust progress and grade slides

14fa0e0

fix: update carousel layout

7c91acf

Merge branch 'feat/course-progress-screen' into feat/upd_home_screen

ff29f91

fix: polish carousel layout

f667edc

fix: align grade slide size

f2cacef

fix: apply demo feedback

72e6451

build: remove xcodes installation (openedx#629)

a3cdc56

feat: fixed conflicts

51bbb7f

feat: home tab carousel

4ef1196

fix: after demo fixes

c9973e2

fix: after demo fixes

5f4f74e

fix: assignment section name fix

ea9eadf

fix: code review fixes

8131be6

fix: unit tests fix

75e7fe4

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 8, 2025

openedx-webhooks added this to Contributions Sep 8, 2025

github-project-automation bot moved this to Needs Triage in Contributions Sep 8, 2025

fix: thumbnail progress bar position fix

bc06b7a

mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Sep 16, 2025

mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 16, 2025

Demian-Yushyn added 3 commits September 17, 2025 08:06

fix: after demo adjustments, ui updates

668684d

fix: chapter progress update

160d631

fix: accessibility message with grade

e1bfa11

fix: remove section name from video, new text added

9cd42f0

IvanStepanok and others added 3 commits September 23, 2025 17:25

feat: course progress page issues (openedx#639)

ca036bb

* fix: address feedback * chore: update oexfoundation library

Merge remote-tracking branch 'origin/develop' into feat/course-home-t…

51cf5c8

…ab-carousel

fix: grades calculation

f415b80

edschema mentioned this pull request Sep 26, 2025

Course Home #616

Closed

Demian-Yushyn added 2 commits September 29, 2025 12:53

fix: grade screen reader, progress animation

e55ac97

fix: removed white border from thumbnail

5829de8

edschema requested a review from RawanMatar89 October 3, 2025 12:59

Demian-Yushyn and others added 3 commits October 7, 2025 17:39

Merge branch 'develop' into feat/course-home-tab-carousel

0a9b273

fix: unit tests

4d686d7

fix: thumbnail size issue and ipad maxwidth size

18ae19a

RawanMatar89 requested changes Oct 21, 2025

View reviewed changes

fix: code review changes

2e24a88

fix: design fixes

b12024f

RawanMatar89 approved these changes Oct 22, 2025

View reviewed changes

IvanStepanok force-pushed the feat/course-home-tab-carousel branch from 657f067 to b12024f Compare October 22, 2025 07:41

fix: sync with develop

ad136d2

volodymyr-chekyrta approved these changes Oct 22, 2025

View reviewed changes

volodymyr-chekyrta merged commit ac55905 into openedx:develop Oct 22, 2025
8 checks passed

github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 22, 2025

IvanStepanok mentioned this pull request Oct 23, 2025

Release v2.2 (Ulmo.1) #646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/course home tab carousel #638

Feat/course home tab carousel #638

Uh oh!

IvanStepanok commented Sep 8, 2025 •

edited

Loading

Uh oh!

openedx-webhooks commented Sep 8, 2025

Uh oh!

edschema commented Sep 23, 2025

Uh oh!

Demian-Yushyn commented Sep 23, 2025

Uh oh!

RawanMatar89 left a comment

Uh oh!

RawanMatar89 Oct 21, 2025

Uh oh!

RawanMatar89 Oct 21, 2025

Uh oh!

RawanMatar89 Oct 21, 2025

Uh oh!

RawanMatar89 Oct 21, 2025

Uh oh!

Demian-Yushyn commented Oct 21, 2025

Uh oh!

RawanMatar89 left a comment

Uh oh!

Uh oh!

codecov bot commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

		}


		func chapterProgressDeep(for chapter: CourseChapter) -> Double {

Feat/course home tab carousel #638

Feat/course home tab carousel #638

Uh oh!

Conversation

IvanStepanok commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Sep 8, 2025

Uh oh!

edschema commented Sep 23, 2025

Uh oh!

Demian-Yushyn commented Sep 23, 2025

Uh oh!

RawanMatar89 left a comment

Choose a reason for hiding this comment

Uh oh!

RawanMatar89 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

RawanMatar89 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

RawanMatar89 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

RawanMatar89 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Demian-Yushyn commented Oct 21, 2025

Uh oh!

RawanMatar89 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 22, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

IvanStepanok commented Sep 8, 2025 •

edited

Loading