Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,7 @@ jobs:
run: npm run test
- name: Build
run: npm run build
- name: Build (CI)
run: npm run build:ci
- name: i18n_extract
run: npm run i18n_extract
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ build:
done' sh {} +
tsc-alias -p tsconfig.build.json

build-ci:
SITE_CONFIG_PATH=site.config.ci.tsx openedx build

# turbo.site.json is the standalone turbo config for this package. It is
# renamed to avoid conflicts with turbo v2's workspace validation, which
# rejects root task syntax (//#) and requires "extends" in package-level
Expand Down
4 changes: 1 addition & 3 deletions dev/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ window.open = (url, target, features) => {
return originalWindowOpen(url, target, features);
};

const devApp: App = {
export const devApp: App = {
appId: 'notifications-dev-site',
routes: [{
path: '/',
Expand All @@ -39,5 +39,3 @@ const devApp: App = {
element: <LinkMenuItem label="Home" url="/" variant="navLink" />,
}],
};

export default devApp;
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"scripts": {
"build": "make build",
"build:ci": "make build-ci",
"build:packages": "make build-packages",
"clean": "make clean",
"clean:packages": "make clean-packages",
Expand Down
24 changes: 24 additions & 0 deletions site.config.ci.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { EnvironmentTypes, SiteConfig, footerApp, headerApp, shellApp } from '@openedx/frontend-base';

import { notificationsApp } from './src';

import '@openedx/frontend-base/shell/style';

const siteConfig: SiteConfig = {
siteId: 'notifications-ci',
siteName: 'Notifications (CI)',
baseUrl: 'http://apps.local.openedx.io',
lmsBaseUrl: 'http://local.openedx.io',
loginUrl: 'http://local.openedx.io/login',
logoutUrl: 'http://local.openedx.io/logout',

environment: EnvironmentTypes.PRODUCTION,
apps: [
shellApp,
headerApp,
footerApp,
notificationsApp,
],
};

export default siteConfig;
4 changes: 2 additions & 2 deletions site.config.dev.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import {
shellApp,
} from '@openedx/frontend-base';

import notificationsApp from './src/app';
import devApp from './dev';
import { notificationsApp } from './src';
import { devApp } from './dev';

import '@openedx/frontend-base/shell/style';

Expand Down
2 changes: 1 addition & 1 deletion site.config.test.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { SiteConfig } from '@openedx/frontend-base';

import notificationsApp from './src/app';
import { notificationsApp } from './src';

const siteConfig: SiteConfig = {
siteId: 'notifications-test',
Expand Down