Skip to content

fix: let composing site own shell and brand CSS#108

Merged
arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes:fix-branding
Apr 22, 2026
Merged

fix: let composing site own shell and brand CSS#108
arbrandes merged 1 commit intoopenedx:frontend-basefrom
arbrandes:fix-branding

Conversation

@arbrandes
Copy link
Copy Markdown
Contributor

@arbrandes arbrandes commented Apr 21, 2026

Description

Mirrors openedx/frontend-base#232. Loads the shell stylesheet via the new @openedx/frontend-base/shell/style JS manifest from site.config.dev.tsx and drops the now-redundant src/app.scss, so lazy-loaded app chunks don't re-declare Paragon's :root tokens.

LLM usage notice

Built with assistance from Claude.

@arbrandes arbrandes linked an issue Apr 21, 2026 that may be closed by this pull request
@arbrandes arbrandes changed the title refactor: let composing site own shell and brand CSS fix: let composing site own shell and brand CSS Apr 21, 2026
@arbrandes arbrandes marked this pull request as draft April 22, 2026 14:36
The shell stylesheet moved from a SCSS file to a JS manifest at
@openedx/frontend-base/shell/style. Imports it directly from
site.config.dev.tsx and drops the now-redundant site.scss.

Mirrors openedx/frontend-base#232.

Co-Authored-By: Claude <noreply@anthropic.com>
@arbrandes arbrandes marked this pull request as ready for review April 22, 2026 15:06
@arbrandes arbrandes merged commit b0c3e73 into openedx:frontend-base Apr 22, 2026
4 checks passed
@arbrandes arbrandes deleted the fix-branding branch April 22, 2026 15:39
@openedx-semantic-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 3.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix frontend-base branding

3 participants