fix: dedupe theme core <link> in useThemeCore#262
Open
arbrandes wants to merge 1 commit into
Open
Conversation
Under React StrictMode the effect ran twice on mount and appended a second core stylesheet after the variant link, letting core :root declarations win over variants that shared the same custom properties. Closes openedx#261 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under React StrictMode the
useThemeCoreeffect ran twice on mount and appended a second core stylesheet after the variant<link>, which let core:rootdeclarations override the variant for any custom properties they happened to share. The effect now looks for an existinglink[data-theme-core="true"]first: if its href matches the target URL it reuses it, and if the URL has changed it removes the stale link before appending the new one. This mirrors the dedup pattern already used byuseThemeVariants.Closes #261
LLM usage notice
Built with assistance from Claude.