Skip to content

feat: wrap slot content operation#195

Open
jesusbalderramawgu wants to merge 1 commit intoopenedx:mainfrom
WGU-Open-edX:feature/wrap-slot-content
Open

feat: wrap slot content operation#195
jesusbalderramawgu wants to merge 1 commit intoopenedx:mainfrom
WGU-Open-edX:feature/wrap-slot-content

Conversation

@jesusbalderramawgu
Copy link
Contributor

Description

PR to add Wrap support to slots, this closes the issue

How this was tested

scenarios with wrap operation were created
Screenshot 2026-03-17 at 9 55 03 a m

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 17, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 17, 2026
@jesusbalderramawgu jesusbalderramawgu self-assigned this Mar 17, 2026
@arbrandes arbrandes changed the title feat: wrap slop content operation supported feat: wrap slot content operation Mar 19, 2026
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable implementation of a wrap operation, but as I reviewed it, I found that there were several fundamental architectural problems. So much so that I'm now convinced we shouldn't allow wrapping at all:

#196

What's missing from that ADR is an example implementation. Do you mind working on a new PR that does what it describes - in other words, a toggle such as the one in frontend-plugin-aspects, but using layouts instead? You could do it in the slot showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants