feat: wrap slot content operation#195
feat: wrap slot content operation#195jesusbalderramawgu wants to merge 1 commit intoopenedx:mainfrom
Conversation
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
This is a reasonable implementation of a wrap operation, but as I reviewed it, I found that there were several fundamental architectural problems. So much so that I'm now convinced we shouldn't allow wrapping at all:
What's missing from that ADR is an example implementation. Do you mind working on a new PR that does what it describes - in other words, a toggle such as the one in frontend-plugin-aspects, but using layouts instead? You could do it in the slot showcase.
Description
PR to add Wrap support to slots, this closes the issue
How this was tested
scenarios with wrap operation were created
