Adding permission validations from authz for Course Updates#2938
Adding permission validations from authz for Course Updates#2938jacobo-dominguez-wgu wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2938 +/- ##
========================================
Coverage 95.51% 95.51%
========================================
Files 1329 1329
Lines 30545 30593 +48
Branches 6924 6729 -195
========================================
+ Hits 29174 29221 +47
- Misses 1303 1316 +13
+ Partials 68 56 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This pr add the permission validations for the Course Updates section on the Content menu from the header.
First this validates the
enableAuthzCourseAuthoringwaffle flag and if it is enabled it checks the permissions from authz over the course updates section.These are the checks included:
Resolves #2932
Supporting information
Depends on backend ticket openedx/openedx-authz#191
Testing instructions
Note
It needs openedx/openedx-authz#191 to be completed to properly test it
It will remain under draft status until the backend is ready.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'