fix: allows docs.openedx.org links to open#12
Open
saraburns1 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 74.19% 74.19%
=======================================
Files 6 6
Lines 62 62
Branches 10 10
=======================================
Hits 46 46
Misses 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructor dashboard -> Reports tab -> Help tab in any of the 3 reports
When you click the Aspects Reference link it opens a new tab and says "docs.openedx.org is blocked"
SDK v0.3.0 sets
allow-popupsbut notallow-popups-to-escape-sandbox, so popups stay inside the sandbox — and a page that sends Cross-Origin-Opener-Policy (docs.openedx.org does) can't load in a sandboxed popup which causes ERR_BLOCKED_BY_RESPONSE.We need to add
allow-popups-to-escape-sandboxto the SDK iframeSandboxExtras