Skip to content

fix: Unauthenticated BFF endpoints should still check logged-in JWT tokens #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pwnage101 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Unauthenticated BFF endpoints should still check logged-in JWT tokens #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions enterprise_access/apps/api/v1/views/bffs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,13 @@
"""
import logging
from collections import OrderedDict
from datetime import datetime

from django.utils import timezone
from drf_spectacular.utils import OpenApiParameter, OpenApiTypes, extend_schema
from edx_rest_framework_extensions.auth.jwt.authentication import JwtAuthentication
from rest_framework import status
from rest_framework.decorators import action
from rest_framework.permissions import IsAuthenticated
from rest_framework.permissions import AllowAny, IsAuthenticated
from rest_framework.response import Response
from rest_framework.throttling import AnonRateThrottle
from rest_framework.viewsets import ViewSet
Expand Down Expand Up @@ -213,8 +212,8 @@ class BaseUnauthenticatedBFFViewSet(BaseBFFViewSetMixin, ViewSet):
Uses BaseHandlerContext which doesn't store customer or user data.
"""

authentication_classes = []
permission_classes = []
authentication_classes = [JwtAuthentication]
permission_classes = [IsAuthenticated | AllowAny]
throttle_classes = [BFFAnonRateThrottle]

def load_route_data_and_build_response(self, request, handler_class, response_builder_class):
Expand Down
Loading