feat : Update search API in learners#2496
Open
sjasti-sonata-svg wants to merge 2 commits intoopenedx:masterfrom
Open
feat : Update search API in learners#2496sjasti-sonata-svg wants to merge 2 commits intoopenedx:masterfrom
sjasti-sonata-svg wants to merge 2 commits intoopenedx:masterfrom
Conversation
iloveagent57
reviewed
Jan 7, 2026
Comment on lines
+112
to
+113
| AND | ||
| ecu.active = 1 |
Contributor
There was a problem hiding this comment.
This seems reasonable. Is there a corresponding unit test we can update to confirm that inactive ECU records are no longer returned in the result set?
Contributor
Author
There was a problem hiding this comment.
Hi @iloveagent57 ,
test_inactive_ecu_records_not_returned() is handling this.
msaha-sonata
suggested changes
Jan 12, 2026
| ecu.enterprise_customer_id = %s | ||
| AND | ||
| ecu.linked = 1 | ||
| AND |
sjasti-sonata-svg
force-pushed
the
feat/ENT-11261-update-learner-search-API
branch
from
9be89e1 to
15ce979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat : Updated search API in learners
Update enterprise learner search API to get only learners records.
ENT-11261.