Skip to content

chore: upgrade ACE logging to promote critical delivery logs from DEB… #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awais-ansari merged 1 commit into from
Jan 12, 2026
+3 −3
Merged

chore: upgrade ACE logging to promote critical delivery logs from DEB… #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions edx_ace/delivery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ def deliver(channel, rendered_message, message):
channel.deliver(message, rendered_message)
except RecoverableChannelDeliveryError as delivery_error:
num_seconds = (delivery_error.next_attempt_time - get_current_time()).total_seconds()
logger.debug('Encountered a recoverable delivery error.')
logger.info('Encountered a recoverable delivery error.')
if delivery_error.next_attempt_time > expiration_time:
logger.debug('Message will expire before delivery can be reattempted, aborting.')
logger.error('Message will expire before delivery can be reattempted, aborting.')
break
logger.debug('Sleeping for %d seconds before reattempting delivery of message.', num_seconds)
time.sleep(num_seconds)
Expand All @@ -65,5 +65,5 @@ def deliver(channel, rendered_message, message):
return

delivery_expired_report = f'{channel_type}_delivery_expired'
logger.debug(delivery_expired_report)
logger.info(delivery_expired_report)
message.report(delivery_expired_report, get_current_time() - start_time)