-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: replace use of mustache templates with edx-utils template #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
728d9cb to
aeb3fb1
Compare
|
@farhan Could you please review these changes? |
Sure, let me prioritize it. |
farhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work overall in removing legacy code.
But it will be great if we could directly update the template library to Django Template Library rather than to Mako templates, because we have already parted ways with Mako templates and shifting the code to Django templates library.
|
@navinkarkera Friendly nudge to follow up on review feedback here. |
|
Update: Sorry, could not find time to work on this yet. I'll try to get it done next week. |
Also removes underscore-min.js file which was unused
aeb3fb1 to
a58ec8b
Compare
|
@farhan We are actually not using mako templates in this repo, the mako like syntax is used by edx.HtmlUtils.template but it has no relation to mako, instead it makes use of lodash.template. I removed mako from requirements here: a58ec8b |
ttqureshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed and tested the changes. LGTM ✔️
cc: @farhan
Also removes underscore-min.js file which was unused