feat (ndm-operator) Allow claim sparse device#679
feat (ndm-operator) Allow claim sparse device#679nobiit wants to merge 1 commit intoopenebs-archive:developfrom
Conversation
niladrih
left a comment
There was a problem hiding this comment.
nit: Should use defined blockdevice type constants when checking for device type.
| FilterBlockDeviceName, | ||
| ) | ||
| } else { | ||
| if c.ClaimSpec.DeviceType != blockdevice.SparseBlockDeviceType { |
There was a problem hiding this comment.
typecheck: undeclared name: blockdevice
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Signed-off-by: Nobi <nobi@nobidev.com>
c54ea7e to
a02ddc6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #679 +/- ##
===========================================
+ Coverage 45.01% 45.32% +0.31%
===========================================
Files 79 79
Lines 3992 3993 +1
===========================================
+ Hits 1797 1810 +13
+ Misses 2028 2014 -14
- Partials 167 169 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Pull Request template
Why is this PR required? What issue does it fix?:
There is currently no way to get a sparse Device
What this PR does?:
Combined with openebs/dynamic-localpv-provisioner#145. It provides a way to get the device sparse by specifying the DeviceType explicitly
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.Where:
Most common types are:
*
feat- for new features, not a new feature for build script*
fix- for bug fixes or improvements, not a fix for build script*
chore- changes not related to production code*
docs- changes related to documentation*
style- formatting, missing semi colons, linting fix etc; no significant production code changes*
test- adding missing tests, refactoring tests; no production code change*
refactor- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes*
cherry-pick- if PR is merged in develop branch and raised to release branch(like v0.4.x)IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.