Skip to content

Refactor custom truststore creation to use Java cacerts as base #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BraisVQ merged 2 commits into from
May 15, 2026
Merged

Refactor custom truststore creation to use Java cacerts as base #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4cb80a
Refactor custom truststore creation to use Java cacerts as base
jorge-romero May 15, 2026
892dfb8
Modify Changelog
jorge-romero May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Update tailor to 1.4.0 ([#1373](https://github.com/opendevstack/ods-core/pull/1373))
- Update Jenkins java version to jdk 21 ([#1374](https://github.com/opendevstack/ods-core/pull/1374))
- Add new configuration for the ODS API Service ([1375](https://github.com/opendevstack/ods-core/pull/1375)) ([1377](https://github.com/opendevstack/ods-core/pull/1377))([1378](https://github.com/opendevstack/ods-core/pull/1378))([1379](https://github.com/opendevstack/ods-core/pull/1379))([1380](https://github.com/opendevstack/ods-core/pull/1380))
- Change the way the certificates are installed in the container of ods-api-service to update the cacert ([1381](https://github.com/opendevstack/ods-core/pull/1381))

### Fixed

Expand Down
6 changes: 4 additions & 2 deletions ods-api-service/docker/install-certs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ fi
CERT_DIR=$(mktemp -d)
echo "Created temporary directory: $CERT_DIR"

echo "Creating new custom truststore from scratch at: $CUSTOM_TRUSTSTORE"
echo "Creating custom truststore based on Java cacerts at: $CUSTOM_TRUSTSTORE"

# Remove existing truststore if it exists
# Copy Java cacerts as the base truststore
rm -f "$CUSTOM_TRUSTSTORE"
cp "$JAVA_HOME/lib/security/cacerts" "$CUSTOM_TRUSTSTORE"
chmod 600 "$CUSTOM_TRUSTSTORE"

# Split CERT_URLS by comma and process each URL
IFS=',' read -ra URLS <<< "$CERT_URLS"
Expand Down
Loading