Feature/display new request deletion dialog#22
Merged
Conversation
jordivx
reviewed
May 6, 2026
| id: '', | ||
| read: false, | ||
| subject: 'only_toast', | ||
| title: 'The request has successfully been sent. Support will receive a Service Now ticket and manage the component deletion.' |
Contributor
There was a problem hiding this comment.
We would need to still display this message if the flow goes through the incident. So 2 different messages for the 2 different scenarios.
Also in this method, the incidentParams should only be fulfilled in that case, in the automatic deletion scenario, it should be an empty array.
| return; | ||
| } | ||
|
|
||
| const dialogRef = this.dialog.open(RequestDeletionDialogComponent, { |
Contributor
There was a problem hiding this comment.
You could include a unit test that verifies that depending on the property opens one or the other dialog
|
jordivx
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.