Skip to content

Stop sending hidden parameters #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordivx merged 1 commit into from
May 4, 2026
Merged

Stop sending hidden parameters #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/app/screens/product-action-screen/product-action-screen.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,4 +972,29 @@ describe('ProductActionScreenComponent', () => {
expect(toastServiceSpy.showToast).not.toHaveBeenCalled();
expect(routerSpy.navigate).toHaveBeenCalledWith(['/project 1/components']);
});

it('should not include parameters with visible set to false in actionParams', () => {
catalogServiceSpy.getProjectProduct.and.returnValue(of({
title: 'fakeProduct',
actions: [
{
id: 'fakeAction',
label: 'Fake Action',
requestable: true,
parameters: [
{ name: 'visible_param', required: true, type: 'string', visible: true },
{ name: 'hidden_param', required: false, type: 'string', visible: false },
{ name: 'another_visible_param', required: false, type: 'string' }
]
}
]
} as AppProduct));

activatedRouteSubject.next({ 'id': 'fakeId', 'catalogSlug': 'catalog', 'action': 'fakeAction' });

const paramNames = component.actionParams.map(p => p.name);
expect(paramNames).not.toContain('hidden_param');
expect(paramNames).toContain('visible_param');
expect(paramNames).toContain('another_visible_param');
});
});
2 changes: 1 addition & 1 deletion src/app/screens/product-action-screen/product-action-screen.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class ProductActionScreenComponent implements OnInit, OnDestroy {
}

private setupActionParameters(productAction: ProductAction): void {
const productActionParams = productAction.parameters?.filter(param => param.name !== 'project_key') || [];
const productActionParams = productAction.parameters?.filter(param => param.name !== 'project_key' && param.visible !== false) || [];

if (productActionParams.length > 0) {
this.addProjectKeyParameter(productActionParams);
Expand Down
Loading