fix(hooks): harden presence registry fail-open (review findings)#666
Merged
NagyVikt merged 2 commits intoJun 30, 2026
Merged
Conversation
added 2 commits
June 30, 2026 03:10
Two sessions editing the same worktree now see each other. Generalize the PostToolUse edit tracker into a per-session presence registry (all files, not just .py; branch/worktree/current-file + last_seen heartbeat) via a shared _session_presence.py, and surface OTHER live sessions in the SessionStart/ UserPromptSubmit advisor on any branch, with per-turn change-detection. Scoped to same-worktree visibility (the reported account.tsx collision). Fail-open and additive: errors leave the protected-branch advisory intact.
- _read_record/read_live_sessions: normalize non-dict JSON to {} so a corrupt
state file can't raise AttributeError and escape the fail-open guard (HIGH)
- _relpath: return None (not basename) when no worktree base, so out-of-tree
edits aren't recorded and can't leak as phantom peers (MEDIUM)
- read_live_sessions: exclude records with empty/missing repo_root from the
worktree-scoped view (MEDIUM)
- record_edit: widen catch to Exception (structural fail-open)
- advisor _write_state: atomic tmp+rename so a partial write can't drop the
advised flag (LOW)
- test: corrupt non-dict state file does not break tracker or advisor
NagyVikt
deleted the
agent/claude/live-session-presence-for-concurrent-cla-2026-06-30-02-47
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).