Fix Windows CI: skip POSIX shell-stub Claude parallel tests#49
Merged
Conversation
The four `parallel --login`/`--run` tests install a fake `claude` on PATH
as a `#!/bin/sh` script and rely on the CLI spawning it. On windows-latest
those cases fail: `commandExists` only resolves PATHEXT extensions
(.EXE/.CMD/.BAT/.COM), so the extensionless stub is invisible; `chmod` is a
no-op; and cmd cannot execute a POSIX shell script. The parallel feature
ships sh/fish wrappers and is POSIX-only, so guard these stub-driven cases
with `{ skip }` on win32. No production behavior change.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI / test (windows-latest, node-{18,20,22})fails on 4 subtests injson-parity.test.ts:parallel --login can reject duplicate Claude accountsparallel --run isolates live Claude sessions and syncs changed login credentialsparallel --run preserves session auth when sync lock is busyparallel --run preserves session auth when another session already changed the profileAll fail with
`claude` (CLI) was not found in PATH.Root cause
These tests install a fake
claudeon PATH as a#!/bin/shscript (chmod 0o755) and rely on the CLI spawning it. On Windows that stub is unreachable:commandExists()only resolvesPATHEXTextensions (.EXE/.CMD/.BAT/.COM), so the extensionlessclaudestub is invisible.chmodis a no-op on Windows.cmdcannot execute a POSIX shell script.The parallel feature itself ships
#!/bin/sh/ fish wrappers and is POSIX-only.Fix
Guard the 4 stub-driven cases with node:test
{ skip }onwin32. No production behavior change; Linux/macOS still run all cases (verified locally: 19 pass, 0 skipped).🤖 Generated with Claude Code