validation: mounts: fix condition of source & type check#660
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Aug 22, 2018
Merged
validation: mounts: fix condition of source & type check#660zhouhao3 merged 1 commit intoopencontainers:masterfrom
zhouhao3 merged 1 commit intoopencontainers:masterfrom
Conversation
|
LGTM (but I'm not maintainer) |
|
LGTM |
|
@alban need rebase. |
The runtime-spec says that [mount source is optional]( https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#mounts). So let's relax condition of the mount source path check, so that it only checks for an empty mount source. Ditto for the type field. The 'mount' test now tries different mount options: bind and not bind, recursive or not, different mount propagation modes. runc passes the test after opencontainers/runc#1845 Closes: opencontainers#651 Based on work from: Dongsu Park <dongsu@kinvolk.io> Signed-off-by: Alban Crequy <alban@kinvolk.io>
dongsupark
force-pushed
the
alban/test-mounts
branch
from
cb7eeeb to
d5be152
Compare
|
@q384566678 Rebased. PTAL |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime-spec says that mount source is optional. So let's relax condition of the mount source path check, so that it only checks for an empty mount source. Ditto for the type field.
The 'mount' test now tries different mount options: bind and not bind, recursive or not, different mount propagation modes.
runc passes the test after opencontainers/runc#1845
Closes: #651
Based on work from: Dongsu Park dongsu@kinvolk.io @dongsupark
Signed-off-by: Alban Crequy alban@kinvolk.io