generate: Set process.args to an empty array if it was nil#59
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom May 10, 2016
Merged
Conversation
wking
force-pushed
the
empty-array-default-for-process.args
branch
from
45256e1 to
1066a92
Compare
Before this commit:
$ ocitools generate --template <(echo '{}')
$ grep args config.json
"args": null,
With this commit:
$ grep args config.json
"args": [],
That's still not a particularly useful value for the process
arguments, but it complies with the specs "array of strings" typing
[1] and is closer to a useful entry (a non-empty array).
[1]: https://github.com/opencontainers/runtime-spec/blob/dbce512cec0cd0774b236980ec18a4f6a91bc77e/config.md#process-configuration
Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit:
With this commit:
That's still not a particularly useful value for the process
arguments, but it complies with the specs “array of strings”
typing (opencontainers/runtime-spec#416) and is closer to a
the useful entry (a non-empty array).