config: Drop redundant "unique within this map" annotation requirement#862
Merged
crosbymichael merged 1 commit intoopencontainers:masterfrom Jun 1, 2017
Merged
Conversation
Contributor
Author
|
This polishing is not changing the spec requirements (just making the spec more efficient about declaring those requirements), so it's not a problem if it lands post-1.0. Can a maintainer tag it v1.NEXT-maybe if it's too much trouble to review now? |
wking
force-pushed
the
redundant-unique-key
branch
from
aa115ac to
eba7304
Compare
This condition landed in 27a05de (Add text about extensions, 2016-06-26, opencontainers#510) with subsequent wording tweaks in 3f0440b (config.md: add empty limit for key of annotations, Dec 28 10:35:19 2016, opencontainers#645) and 2c8feeb (config: Bring "unique... within this map" back together, 2017-01-12, opencontainers#654). However, since eeaccfa (glossary: Make objects explicitly unordered and forbid duplicate names, 2016-09-27, opencontainers#584) we forbid duplicate keys on *all* objects (not just annotations), so this PR removes the redundant annotation-specific condition. Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
Author
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This condition landed in #510 with subsequent wording tweaks in #645 and #654. However, since #584 we forbid duplicate keys on all objects (not just annotations), so this PR removes the redundant annotation-specific condition.