config: Remove "MAY support any valid values" sentence#851
Merged
crosbymichael merged 1 commit intoopencontainers:masterfrom Jun 1, 2017
Merged
Conversation
Member
|
@wking can you please rebase this |
Contributor
|
Needs rebase |
wking
force-pushed
the
remove-may-support-any-valid-values
branch
from
27cb1c5 to
76c740e
Compare
This line landed in 718f9f3 (origin/pr/673) minor narrative cleanup regarding config compatibility, 2017-01-30, opencontainers#673), but I'm not clear on the motivation. The wording reads to me like "you don't have to support valid values for platform-specific fields if you don't want to", but we already cover unsupported value handling with the "MUST generate an error when invalid or unsupported values are encountered" language separated out in c763e64 (config: Move valid-value rules to their own section, 2017-02-07, opencontainers#681). This commit removes the ambiguous line. Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line landed in #673, but I'm not clear on the motivation. The wording reads to me like “you don't have to support valid values for platform-specific fields if you don't want to”, but we already cover unsupported value handling with the valid values section separated out in #681. This commit removes the ambiguous line.
Related issue in #813, although this commit will not close that issue.