Set specs value the same as kernel API input#704
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Mar 1, 2017
Merged
Set specs value the same as kernel API input#704mrunalp merged 1 commit intoopencontainers:masterfrom
mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
This partially revert opencontainers#648 , after a second thought, I think we should use specs value the same as kernel API input, see: opencontainers#692 (comment) For memory and hugetlb limits *.limit_in_bytes, cgroup APIs take the values as string, but the parsed values are unsigned long, see: https://github.com/torvalds/linux/blob/v4.10/mm/page_counter.c#L175-L193 For `cpu.cfs_quota_us` and `cpu.rt_runtime_us`, cgroup APIs take the input value as signed long long, while `cpu.cfs_period_us` and `cpu.rt_periof_us` take the input value as unsigned long long. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Member
|
LGTM |
Contributor
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially revert #648 , after a second thought, I think we
should use specs value the same as kernel API input, see:
#692 (comment)
For memory and hugetlb limits *.limit_in_bytes, cgroup APIs take the values
as string, but the parsed values are unsigned long, see:
https://github.com/torvalds/linux/blob/v4.10/mm/page_counter.c#L175-L193
For
cpu.cfs_quota_usandcpu.rt_runtime_us, cgroup APIs take the inputvalue as signed long long, while
cpu.cfs_period_usandcpu.rt_periof_ustake the input value as unsigned long long.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com