change the type of hugepageLimits.limit to uint64#659
Closed
Kxuan wants to merge 1 commit intoopencontainers:masterfrom
Closed
change the type of hugepageLimits.limit to uint64#659Kxuan wants to merge 1 commit intoopencontainers:masterfrom
Kxuan wants to merge 1 commit intoopencontainers:masterfrom
Conversation
The limit should not be lower than 0. Signed-off-by: Zhai Zhao Xuan <kxuanobj@gmail.com>
Contributor
|
On Tue, Jan 17, 2017 at 11:21:54PM -0800, Xuan wrote:
The limit should not be lower than 0.
…
* change the type of hugepageLimits.limit to uint64
This was just changed from a uint64 to an int64 in #648, although
we're still missing docs explaining what -1 is for [1].
[1]: #648 (comment)
|
Author
|
Ok. I get it. I'm trying to add hugepageLimit to runtime-tools, but the type of HugepageLimit.Limit is different between runtime-tools and runtime-spec. Thanks |
Contributor
|
On Tue, Jan 17, 2017 at 11:45:43PM -0800, Xuan wrote:
I think we need to find some method to sync the runtime-spec and
runtime-tools.
@crosbymichael has called for a spec-schema feature freeze in the near
future [1], although as far as I know the runtime-spec maintainers
have not officially put a date on that yet. If/when that happens, it
will give runC and other Go consumers time to catch up anything they
don't vendor directly from runtime-spec (or to bump their vendored
version if they do vendor runtime-spec).
[1]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/2017/opencontainers.2017-01-11-22.04.log.html#l-33
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limit should not be lower than 0.