[Style] Remove "should" not related to conformance#536
[Style] Remove "should" not related to conformance#536RobDolinMS wants to merge 3 commits intoopencontainers:masterfrom
Conversation
The style.md file includes the word "should" which may unintentionally be confused with "SHOULD" as used to identify a conformance/certification requirement. This pull request removes the word "should" so there is not confusion Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
style.md
Outdated
| ## One sentence per line | ||
|
|
||
| To keep consistency throughout the Markdown files in the Open Container spec all files should be formatted one sentence per line. | ||
| To keep consistency throughout the Markdown files in the Open Container spec format all files one sentence per line. |
There was a problem hiding this comment.
“spec format” → “spec, format”
|
On Mon, Aug 22, 2016 at 12:28:23PM -0700, Rob Dolin (MSFT) wrote:
ALL CAPS are pretty striking. And style.md is fairly clearly |
|
On Mon, Aug 22, 2016 at 12:28:23PM -0700, Rob Dolin (MSFT) wrote:
“realted” → “related” |
Signed-off-by: Rob Dolin <robdolin@microsoft.com>
Signed-off-by: Rob Dolin <robdolin@microsoft.com>
RobDolinMS
changed the title
|
I believe all of the issues @wking raised have now been addressed (including my typo in the PR title) |
|
Everything through 6d500fb looks good to me. Maybe squash down to a
single commit, but that's not a big deal.
|
|
LGTM |
|
There is still a signed off missing on a commit, it would be better to just squash them all. |
|
LGTM, and appears to be all-signed-off to me (and Travis agrees) 👍 |
|
It's |
|
Not seeing any issues here, pullapprove...
|
|
Interesting, I wonder what emails @RobDolinMS has associated with this github account. Is it robdolin@microsoft.com? |
|
@caniszczyk did we ever figure out what's causing @RobDolinMS to be shafted by PullApprove? 😢 |
|
On Fri, Nov 04, 2016 at 03:56:53PM -0700, Tianon Gravi wrote:
My random guess is that he has (MSFT) in his author field but not in $ git show origin/pr/536 | head -n 7 |
|
@RobDolinMS could you try matching the Author and Signed-off-by name? |
|
@RobDolinMS when you have time please rebase your PRs and make sure your sign off is correct. Feel free to reopen when they have been updated. |
7 participants
The style.md file includes the word "should" which may unintentionally be confused with "SHOULD" as used to identify a conformance/certification requirement.
This pull request removes the word "should" so there is not confusion
Signed-off-by: Rob Dolin robdolin@microsoft.com