schema: Replace "bundle" with "runtime configuration"#453
Closed
wking wants to merge 1 commit intoopencontainers:masterfrom
Closed
schema: Replace "bundle" with "runtime configuration"#453wking wants to merge 1 commit intoopencontainers:masterfrom
wking wants to merge 1 commit intoopencontainers:masterfrom
Conversation
wking
force-pushed
the
bundle-to-runtime-config
branch
from
ceb4efb to
05fbfa3
Compare
The bundle contains 'config.json' and other things, but this schema is just for 'config.json'. This is mostly: $ sed -i 's|/bundle|/runtime/config|' schema/*.json for the 'id' fields, but I also tweaked 'root.description' and the schema.json 'description'. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
bundle-to-runtime-config
branch
from
05fbfa3 to
cccd9fc
Compare
Contributor
|
Hmm, not sure @vbatts WDYT? |
Member
|
-1 We are NOT getting rid of the bundle concept at this point. |
Member
|
We already discussed this on the call and agreed on keeping it. |
Contributor
Author
|
On Wed, May 25, 2016 at 10:54:06AM -0700, Michael Crosby wrote:
This commit was not about getting rid of the bundle concept (although To make the distinction more clear, I'll file a PR to add JSON Schema |
This was referenced May 25, 2016
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jun 1, 2016
To make it clear that these schemas are for validating config.json (and not, for example, state JSON). I've left the IDs alone for now, because my PR adjusting those was rejected [1]. [1]: opencontainers#453 Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jun 3, 2016
To make it clear that these schemas are for validating config.json (and not, for example, state JSON). I've left the IDs alone for now, because my PR adjusting those was rejected [1]. The rule for the -schema portion is "use it for entrypoint files" [2]. [1]: opencontainers#453 [2]: opencontainers#481 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jun 6, 2016
To make it clear that these schemas are for validating config.json (and not, for example, state JSON). I've left the IDs alone for now, because my PR adjusting those was rejected [1]. The rule for the -schema portion is "use it for entrypoint files" [2]. [1]: opencontainers#453 [2]: opencontainers#481 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Jun 9, 2016
To make it clear that these schemas are for validating config.json (and not, for example, state JSON). I've left the IDs alone for now, because my PR adjusting those was rejected [1]. The rule for the -schema portion is "use it for entrypoint files" [2]. [1]: opencontainers#453 [2]: opencontainers#481 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
To make it clear that these schemas are for validating config.json (and not, for example, state JSON). I've left the IDs alone for now, because my PR adjusting those was rejected [1]. The rule for the -schema portion is "use it for entrypoint files" [2]. [1]: opencontainers#453 [2]: opencontainers#481 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle contains
config.jsonand other things, but this schema is just forconfig.json. This is mostly:for the
idfields, but I also tweakedroot.descriptionandconfig.json'sdescription.