config.md: Remove 'solaris' from full example#436
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom May 18, 2016
Merged
config.md: Remove 'solaris' from full example#436mrunalp merged 1 commit intoopencontainers:masterfrom
mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
This should have been part of 759ee79 (config: Add platform-specific entry for 'solaris', 2016-05-06, opencontainers#431), since the example has platform.os set to 'linux'. There was some (brief) discussion of this point before the 'solaris' section landed [1], but the "should only be set if" wording landed in parallel via b373a15 (config: Split platform-specific configuration into its own section, 2016-05-02, opencontainers#414), and I'd forgotten to go back and apply that logic to opencontainers#411. Having a full Solaris example would be useful, but I think it should be a separate, Solaris-only example. [1]: opencontainers#411 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
remove-solaris-from-full-config
branch
from
17f77d4 to
a044e07
Compare
Contributor
|
Yeah, it makes sense to create a different solaris example. |
Contributor
Author
|
On Wed, May 18, 2016 at 07:12:13AM -0700, Mrunal Patel wrote:
Should that happen in this PR? I'm not familiar enough with Solaris |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
This is fine, I will work on the Solaris only example in the coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should have been part of 759ee79 (config: Add platform-specific entry for 'solaris', 2016-05-06, #431), since the example has
platform.osset tolinux.There was some (brief) discussion of this point before the
solarissection landed, but the “should only be set if” wording landed in parallel via b373a15 (config: Split platform-specific configuration into its own section, 2016-05-02, #414), and I'd forgotten to go back and apply that logic to #411.Having a full Solaris example would be useful, but I think it should be a separate, Solaris-only example.