Conversation
|
|
||
| #### further subheader | ||
|
|
||
| ### Example |
There was a problem hiding this comment.
Maybe clarify that this is an example of “some topic”. And if we prefer Sentence casing or Title Casing, it's probably best to use that throughout this Markdown literal as well.
There was a problem hiding this comment.
I agree with @wking. I was confused on first read of lines 28-34 until I read Trevor's comment.
There was a problem hiding this comment.
this is not all what we do today.
|
On Wed, Mar 16, 2016 at 07:43:44PM -0700, Vincent Batts wrote:
This is great :). I left a few nits in inline, but I'm happy with |
|
Looks fine. Needs rebase. |
|
rebased. PTAL. |
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
updated |
style.md
Outdated
| [no-pointer-for-boolean]: https://github.com/opencontainers/specs/pull/290#discussion_r50296396 | ||
| [no-pointer-for-slices]: https://github.com/opencontainers/specs/pull/316/files#r50782982 | ||
| [optional-pointer]: https://github.com/opencontainers/specs/pull/233#discussion_r47829711 | ||
| [pointer-when-updates-require-changes]: https://github.com/opencontainers/specs/pull/317/files#r50932706 |
There was a problem hiding this comment.
You probably didn't mean to touch the opencontainers/runtime-spec links.
There was a problem hiding this comment.
rebased on master ... not sure why those seem touched
On Fri, Apr 8, 2016 at 1:41 PM, W. Trevor King notifications@github.com
wrote:
In style.md
#348 (comment)
:-[integer-over-hex]: #267 (comment)
-[keep-prefix]: #159 (comment)
-[no-pointer-for-boolean]: #290 (comment)
-[no-pointer-for-slices]: https://github.com/opencontainers/runtime-spec/pull/316/files#r50782982
-[optional-pointer]: #233 (comment)
-[pointer-when-updates-require-changes]: https://github.com/opencontainers/runtime-spec/pull/317/files#r50932706
+[integer-over-hex]: #267 (comment)
+[keep-prefix]: #159 (comment)
+[no-pointer-for-boolean]: #290 (comment)
+[no-pointer-for-slices]: https://github.com/opencontainers/specs/pull/316/files#r50782982
+[optional-pointer]: #233 (comment)
+[pointer-when-updates-require-changes]: https://github.com/opencontainers/specs/pull/317/files#r50932706You probably didn't mean to touch the opencontainers/runtime-spec links.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/348/files/a2772db1d89eb9604010aa811cf99e34ae3ddcf5#r59062479
There was a problem hiding this comment.
oh i see. "runtime-spec". lemme fix that.
On Fri, Apr 8, 2016 at 1:44 PM, Vincent Batts vbatts@hashbangbash.com
wrote:
rebased on master ... not sure why those seem touched
On Fri, Apr 8, 2016 at 1:41 PM, W. Trevor King notifications@github.com
wrote:In style.md
#348 (comment)
:-[integer-over-hex]: #267 (comment)
-[keep-prefix]: #159 (comment)
-[no-pointer-for-boolean]: #290 (comment)
-[no-pointer-for-slices]: https://github.com/opencontainers/runtime-spec/pull/316/files#r50782982
-[optional-pointer]: #233 (comment)
-[pointer-when-updates-require-changes]: https://github.com/opencontainers/runtime-spec/pull/317/files#r50932706
+[integer-over-hex]: #267 (comment)
+[keep-prefix]: #159 (comment)
+[no-pointer-for-boolean]: #290 (comment)
+[no-pointer-for-slices]: https://github.com/opencontainers/specs/pull/316/files#r50782982
+[optional-pointer]: #233 (comment)
+[pointer-when-updates-require-changes]: https://github.com/opencontainers/specs/pull/317/files#r50932706You probably didn't mean to touch the opencontainers/runtime-spec links.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/348/files/a2772db1d89eb9604010aa811cf99e34ae3ddcf5#r59062479
vbatts
force-pushed
the
anchor-examples
branch
2 times, most recently
from
7093aad to
e49ab0f
Compare
|
Commits through e49ab0f look good to me, excepting 1 calling for FooBarBazExampleTo use Baz, … ExampleTo use Foo, … would make me happier (and the one-word headings avoid the need for a |
addressing: * anchoring * content of example Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
done. PTAL. |
|
LGTM |
1 similar comment
|
LGTM |
5 participants
This cleans up the anchoring of examples and adds to the style and conventions of such.