lifecycle: Don't require /run/opencontainer/<runtime>/containers#269
lifecycle: Don't require /run/opencontainer/<runtime>/containers#269hqhq merged 1 commit intoopencontainers:masterfrom
Conversation
|
LGTM |
|
I'd prefer to NOT do this because we're replacing a concrete, and interoperable, solution with something that is not. If we don't like the current proposal then I think it would be better to only remove it when there's a viable alternative proposed - replace it with just "write it to the filesystem" doesn't help interop. |
We already require it for Linux/Unix-based systems [1], so we don't have to repeat it here. And other systems will use different paths, which we haven't specified yet. When I asked why we didn't specify a path for Windows [2], Vincent said we were waiting on help from PoC implementations [3]. So this commit punts the location to the "State" section, and lets the "Lifecycle" section just focus on when the write-to-filesystem happens. There's also discussion about removing the filesystem state registry completely [4], in which case we'd want to remove the whole line from the lifecycle. [1]: opencontainers@7713efc#diff-b84a8d65d8ed53f4794cd2db7e8ea731L7 [2]: opencontainers#211 (comment) [3]: opencontainers#211 (comment) [4]: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/q6TYqVZOcX8 Subject: removal of /run/opencontainer/containers Date: Wed, 25 Nov 2015 14:29:35 +0000 Message-ID: <CAD2oYtNipt3i_C6=J4Bc-jwauo5YAvKXUqTROnPNP3vZ9+C5Vw@mail.gmail.com> Signed-off-by: W. Trevor King <wking@tremily.us>
|
On Mon, Dec 14, 2015 at 09:51:11AM -0800, Doug Davis wrote:
This PR doesn't change the semantics for Linux/Unix-based systems, |
5402c1c to
f89cb85
Compare
|
@wking ah, doi - sorry missed that. I take back my concerns :-) |
|
LGTM |
lifecycle: Don't require /run/opencontainer/<runtime>/containers
As discussed in #231. We already require it for
Linux/Unix-based systems, so we don't have to repeat it here. And
other systems will use different paths, which we haven't specified
yet. When I asked why we didn't specify a path for Windows,
Vincent said we were waiting on help from PoC implementations.
So this commit punts the location to the “State” section, and lets the
“Lifecycle” section just focus on when the write-to-filesystem
happens.
There's also discussion about removing the filesystem state registry
completely, in which case we'd want to remove the whole line from
the lifecycle. If we expect to switch to something like
--state PATHin the near future this PR is just polishing deaddocumentation.