Skip to content

Switch to Go 1.24 as a min version, bump CI, modernize sources#4851

Merged
rata merged 4 commits intoopencontainers:mainfrom
kolyshkin:go124-min
Aug 28, 2025
Merged

Switch to Go 1.24 as a min version, bump CI, modernize sources#4851
rata merged 4 commits intoopencontainers:mainfrom
kolyshkin:go124-min

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Aug 14, 2025

See individual commits for details. High level overview:

  • libct/sys/rlimit_linux: drop unused go:build tag
  • require go 1.24, add go 1.25 to CI, drop go 1.23
  • types/events: use omitzero where appropriate
  • modernize code for Go 1.24

Similar cgroups PR: opencontainers/cgroups#28

@kolyshkin kolyshkin marked this pull request as ready for review August 14, 2025 03:45
@kolyshkin

This comment was marked as duplicate.

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

Copy link
Copy Markdown
Contributor Author

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased

@rata rata enabled auto-merge August 18, 2025 12:47
Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, left a question about the possible breaking change.

I didn't know of modernize, very nice :)

Comment thread types/events.go
Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rata
Copy link
Copy Markdown
Member

rata commented Aug 19, 2025

@kolyshkin there are conflicts, but after that auto-merge I guess should work :)

@cyphar cyphar added this to the 1.4.0-rc.1 milestone Aug 27, 2025
This is not needed since commit 16d7336 which sets 1.23 to be a
minimally required Go version.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Now that Go 1.25 is out, let's switch to go 1.24.0 as a minimally
supported version, drop Go 1.23 and add Go 1.25 to CI matrix.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In these cases, omitempty doesn't really work so it is useless,
but omitzero actually works.

As a result, output of `runc events` may omit these fields if all they
contain are zeroes.

NOTE this might be a breaking change.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Brought to you by

	modernize -fix -test ./...

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@rata rata merged commit f8bb8ac into opencontainers:main Aug 28, 2025
36 checks passed
Copy link
Copy Markdown
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fwiw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants