Make cwd required

[mrunalp]

Signed-off-by: Mrunal Patel mrunalp@gmail.com

[mrunalp]

This is related to the spec change we made to make cwd required.

[crosbymichael]

@mrunalp maybe some of the tests need the template updated with a cwd to fix the test failures.

[crosbymichael]

What do you think about moving this validation to loadSpec()?

[mrunalp]

Sure, will do.

[mrunalp]

Updated wit the tests fixed. There is some issue on jenkins, the tests aren't even run.

[hqhq]

LGTM if janky is happy.

[duglin]

if opencontainers/runtime-spec#312 is adopted before this PR is merged, can you add a check to ensure its an abs path? filepath.IsAbs()

[mrunalp]

Sure.

Sent from my iPhone

On Jan 15, 2016, at 6:14 AM, Doug Davis notifications@github.com wrote:

In spec.go:

@@ -290,6 +291,15 @@ var mountPropagationMapping = map[string]int{
"": syscall.MS_PRIVATE | syscall.MS_REC,
}

+// validateSpec validates the fields in the spec
+// TODO: Add validation for other fields where applicable
+func validateSpec(spec *specs.LinuxSpec, rspec *specs.LinuxRuntimeSpec) error {

• if spec.Process.Cwd == "" {
  if Make cwd an abs path to avoid ambiguity runtime-spec#312 is adopted before this PR is merged, can you add a check to ensure its an abs path? filepath.IsAbs()

—
Reply to this email directly or view it on GitHub.

[mrunalp]

@jfrazelle ping; Something wrong with the jenkins server.

[LK4D4]

LGTM