Skip to content

libct/intelrdt: remove unused type#3305

Merged
thaJeztah merged 1 commit intoopencontainers:masterfrom
kolyshkin:rdt-4
Dec 2, 2021
Merged

libct/intelrdt: remove unused type#3305
thaJeztah merged 1 commit intoopencontainers:masterfrom
kolyshkin:rdt-4

Conversation

@kolyshkin
Copy link
Contributor

Since PR #2920, type intelRdtData is only used by tests,
and its only member is config.

Change the test to use config directly, and remove the type.

Partially generated by

sed -i -e 's/helper.IntelRdtData.config/helper.config/g' intelrdt_test.go

Since commit 7296dc1, type intelRdtData is only used by tests,
and since commit 79d292b, its only member is config.

Change the test to use config directly, and remove the type.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

@marquiz @xiaochenshen @Creatone PTAL

@xiaochenshen
Copy link
Contributor

@kolyshkin LGTM.
Thank you.

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kolyshkin. I could've spotted that myself 🙄
LGTM

Copy link

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kolyshkin LGTM

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 45c31f9 into opencontainers:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants