libcontainer/specconv/spec_linux: Use golang.org/x/sys/unix#1445
Closed
wking wants to merge 1 commit intoopencontainers:masterfrom
Closed
libcontainer/specconv/spec_linux: Use golang.org/x/sys/unix#1445wking wants to merge 1 commit intoopencontainers:masterfrom
wking wants to merge 1 commit intoopencontainers:masterfrom
Conversation
syscall is deprecated [1] and sys/unix contains newer flags like MS_LAZYTIME [2] which we need to implement all the filesystem-independent mount options referenced from the spec [3]. [1]: https://golang.org/pkg/syscall/ [2]: https://godoc.org/golang.org/x/sys/unix [3]: https://github.com/opencontainers/runtime-spec/blame/v1.0.0-rc5/config.md#L68 Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
This is a dup of #1442, isn't it? |
Contributor
Author
Contributor
Author
|
On Wed, May 10, 2017 at 10:09:03PM -0700, Tianon Gravi wrote:
This is a dup of #1442, isn't it?
It's a smaller chunk (just what I need for
opencontainers/runtime-spec#771). But it looks like Travis is happy
with #1442 at the moment [1], so if it's easier to review the more
comprehensive PR that works for me.
[1]: https://travis-ci.org/opencontainers/runc/builds/230550007
|
Member
|
This is a dup of #1442, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syscallis deprecated andsys/unixcontains newer flags likeMS_LAZYTIMEwhich we need to implement all the filesystem-independent mount options referenced from the spec.Related to opencontainers/runtime-spec#771.