.pullapprove.yml: Count rejections against#31
Closed
wking wants to merge 1 commit intoopencontainers:mainfrom
Closed
.pullapprove.yml: Count rejections against#31wking wants to merge 1 commit intoopencontainers:mainfrom
wking wants to merge 1 commit intoopencontainers:mainfrom
Conversation
Contributor
Author
Contributor
Author
|
The PullApprove failure is because we don't have a |
Contributor
|
@wking it's been renamed: https://github.com/orgs/opencontainers/teams/selinux-maintainers |
Distinguish between "I haven't looked at this" (no need to say anything) and "I have looked at this and don't like it" (say something matching the reject_regex). Docs in http://docs.pullapprove.com/groups/reject_value/ Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
Author
|
On Mon, Mar 20, 2017 at 02:07:35PM -0700, Chris Aniszczyk wrote:
@wking it's been renamed:
https://github.com/orgs/opencontainers/teams/selinux-maintainers
That page 404s for me (probably because it needs some admin-ish
permissions), but I expect you mean that the selinux-maintainers team
exists now (and may have before as well). I bumped CommitDate to get
a new hash and pushed fa72f6b → 78ece86 to get PullApprove to take
another look at this PR, but it's still complaining about a missing
selinux-maintainers team on this repo [1]. Maybe you forgot to
associate that team with *this* repo? It should be associated with
both this repo *and* the selinux repo.
[1]: https://pullapprove.com/opencontainers/project-template/pull-request/31/requirements/
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish between “I haven't looked at this” (no need to say anything) and “I have looked at this and don't like it” (say something matching the reject_regex).
Spun off from #29, since it's an independent change and there was some question about whether we want it. I think we do want it, but either way, there's no need to hold up #29 before we decide on this point. #29 should be reviewed first, because this commit sits on top of it.
Docs here.