image-index: define platform.os.features on Windows#652
image-index: define platform.os.features on Windows#652stevvooe merged 1 commit intoopencontainers:masterfrom
Conversation
image-index.md
Outdated
| This OPTIONAL property specifies an array of strings, each specifying a mandatory OS feature. | ||
| For Windows, image indexes SHOULD use, and implementations SHOULD understand the following values: | ||
| - `win32k`: image requires `win32k.sys` on the host (Note: `win32k.sys` is missing on Nano Server) | ||
| Convention for other features SHOULD be submitted to this specification for standardization. |
There was a problem hiding this comment.
I liked your #650 wording for this better. How about:
When
osis notwindows, values are implementation-defined and SHOULD be submitted to this specification for standardization.
Alternatively, I'm fine reserving this for non-Windows OSes.
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
force-pushed
the
platform-os-features
branch
from
5f52aba to
922ccc1
Compare
|
@RobDolinMS can you get someone to review this, please? |
|
@RobDolinMS PTAL? |
|
@darrenstahlmsft would you please give this a look? |
|
Tagging @jstarks to take a look. |
|
bump |
|
Waiting for results. |
|
we're 30+ days on getting a review for this. I'm in favor of bumping this to post 1.0 so it is not a blocker |
|
100%, lets move to post 1.0 |
|
I move to open another PR to simply reserve these fields. @AkihiroSuda Do you mind leaving this PR open and we'll reserve these fields for a future version? |
|
no problem |
|
@stevvooe so, post-v1.0.0? or are you opening a PR for the reserve language? |
|
Maybe this is a day late and a dollar short, but LGTM. |
|
LGTM |
1 similar comment
|
LGTM |
8 participants
Please refer to #632 for previous discussion.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp