Makefile: Use 'ifdef TRAVIS_COMMIT_RANGE' for git-validation#521
Merged
jonboulle merged 2 commits intoopencontainers:masterfrom Jan 24, 2017
Merged
Makefile: Use 'ifdef TRAVIS_COMMIT_RANGE' for git-validation#521jonboulle merged 2 commits intoopencontainers:masterfrom
jonboulle merged 2 commits intoopencontainers:masterfrom
Conversation
Only use the auto-ranging when Travis tells us what the range is. Use our EPOCH_TEST_COMMIT-based range in all other cases. ifdef is described in [1]. [1]: https://www.gnu.org/software/make/manual/html_node/Conditional-Syntax.html Signed-off-by: W. Trevor King <wking@tremily.us>
To make make debugging Travis environment issues more straightforward. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
makefile-travis-ifdef
branch
from
eab34ae to
8236f61
Compare
This was referenced Jan 23, 2017
Member
|
LGTM |
jonboulle
reviewed
Jan 24, 2017
| install: true | ||
|
|
||
| script: | ||
| - env | grep TRAVIS_ |
Contributor
Author
There was a problem hiding this comment.
what is this?
A way to see what Travis-specific variables were set for a given build.
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only use the auto-ranging when Travis tells us what the range is. Use our
EPOCH_TEST_COMMIT-based range in all other cases.This may fix the issue we've been having with #514.