specs-go/v1: add nondistributable media type#297
specs-go/v1: add nondistributable media type#297philips merged 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
While we're filling in the pieces, img/media-types.dot and one of the
entries in schema/manifest_test.go should probably be updated too.
|
what's wrong with schema/manifest_test.go? just add a test? |
|
On Mon, Sep 12, 2016 at 11:04:57AM -0700, Antonio Murdaca wrote:
We should exercise the new type to make sure the image tooling handles |
@wking that's the wrong test for sure since it's already a mess with media types like ".serialization." but it is not failing since that is testing the MANIFEST as a whole - not that the media types are actually correct... you don't exercise anything in that test - just that the media type field isn't empty... |
Takes care of adding the new media type in the Go types from #233 - so that can proceed and be merged w/o any other interruption.
/cc @stevvooe @philips @vbatts
Signed-off-by: Antonio Murdaca runcom@redhat.com