Fix a grammar mistake in serialization.md and don't imply _ is valid in dns hostnames#161
Closed
jbouzane wants to merge 1 commit intoopencontainers:masterfrom
jbouzane:patch-1
Closed
Fix a grammar mistake in serialization.md and don't imply _ is valid in dns hostnames#161jbouzane wants to merge 1 commit intoopencontainers:masterfrom jbouzane:patch-1
jbouzane wants to merge 1 commit intoopencontainers:masterfrom
jbouzane:patch-1
Conversation
jbouzane
commented
Jun 20, 2016
- Fix a grammar error ("follow comply" -> "comply")
- Underscores are invalid in hostnames in DNS; fix the text not to imply they are valid.
Member
Contributor
|
On Mon, Jun 20, 2016 at 04:26:01PM -0700, Vincent Batts wrote:
Test failures look unrelated (e.g. 1). |
Contributor
Member
|
doesn't seem related (on my laptop) |
Member
|
well, unless CI is running the old |
Contributor
|
On Mon, Jun 20, 2016 at 05:00:45PM -0700, Antonio Murdaca wrote:
Travis history for master broke at build 337 [1,2], which was after #158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.