UEC Congestion Signaling Protocol #2231
Open
+1,016
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Port and Switch Attributes Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG ACL Attributes Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG TAM Attributes Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Time Interval Unit Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Document Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Document Signed-off-by: JaiOCP <jai.kumar@broadcom.com> CSIG Document Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Fix: "INVAILD" typo in enum '_sai_dash_flow_entry_bulk_get_session_filter_key_t' (opencomputeproject#2224) This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID. Changes: saitypesextensions.h: Renamed enum member INVAILD → INVALID. Following will be pushed to DASH's repo once these SAI repo changes are merged. dash_headers.p4: Renamed enum member INVAILD → INVALID. Non UEC Member Agreement Form (opencomputeproject#2226) Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Seamless BFD (S-BFD) (opencomputeproject#2220) Signed-off-by: Jason Bos <jbos@cisco.com> Replicate VXLAN UDP sport security to switch level (opencomputeproject#2195) - Add SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY attribute to drop tunnel packets with UDP source port outside allowed range - Add documentation for UDP source port validation on VXLAN packet ingress - Update both saiswitch.h and saitunnel.h with security clarifications Signed-off-by: Marian Pritsak <marianp@mellanox.com> SRv6 SID Marking (opencomputeproject#2222) * SID Marking APIs Signed-off-by: Jason Bos <jbos@cisco.com> [DASH] Add flow bulk get session event data struct (opencomputeproject#2175) * [DASH] Add flow bulk get session event data struct Add flow bulk get event callback and supporting structures to provide ability to query flows in asynchronous manner. Introducing SAI_PORT_ATTR_PORT_PG_PKT_DROP_STATUS (opencomputeproject#2234) In this map, the key is the PG index and the status value (clear-on-read) for each PG is from {0, 1}, where 0 indicates no drops were observed and 1 indicates packet drops. Signed-off-by: Prasun Sinha <prasunsinha@google.com> Add flow entry to the bulk session event data (opencomputeproject#2237) Add the ability to query the flows with the bulk get session event data callback. The commit contains a fix for bad ordering of classes generated by Thrift compiler for the nested structures used in this callback. Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
rck-innovium
reviewed
Jan 8, 2026
| SAI_TAM_INT_ATTR_QUANT_BAND_UINT32_RANGE_LIST, | ||
|
|
||
| /** | ||
| * @brief Base value for wide tag quantization. Must be power of 2 |
Contributor
There was a problem hiding this comment.
Capturing 01/08 review comments: Must be 0 or power of 2
| * @flags CREATE_AND_SET | ||
| * @default SAI_CSIG_SIGNAL_TYPE_ABW | ||
| */ | ||
| SAI_TAM_INT_ATTR_CSIG_SIGNAL_TYPE, |
Contributor
There was a problem hiding this comment.
Capturing 01/08 review comments: Units for ABW and ABW/C
| /** | ||
| * @brief Quantization band range values for compact tag | ||
| * | ||
| * @type sai_u32_range_list_t |
Contributor
There was a problem hiding this comment.
Capturing 01/08 review comments: need sai_u64_range_list_t
| * @default disabled | ||
| */ | ||
| SAI_ACL_ENTRY_ATTR_FIELD_CSIG_SIGNAL_TYPE = SAI_ACL_ENTRY_ATTR_FIELD_START + 0x165, | ||
|
|
Contributor
There was a problem hiding this comment.
Capturing 01/08 review comments: Include match on the D-bit
|
|
||
|
|
||
| // Query CSIG signals supported | ||
| sai_query_attribute_capability(switch_id, SAI_OBJECT_TYPE_TAM_INT, |
Contributor
There was a problem hiding this comment.
We should use sai_query_attribute_enum_values_capability() instead of sai_query_attribute_capability(). The last param should be of type sai_s32_list_t and not sai_attr_capability_t
| sai_attr_capability_t csig_tag_capability={0}; | ||
|
|
||
| // Query CSIG tag support for compact and/or wide tag | ||
| sai_query_attribute_capability(switch_id, SAI_OBJECT_TYPE_TAM_INT, |
Contributor
There was a problem hiding this comment.
We should use sai_query_attribute_enum_values_capability() instead of sai_query_attribute_capability(). The last param should be of type sai_s32_list_t and not sai_attr_capability_t
| * @isvlan false | ||
| * @default 0 | ||
| */ | ||
| SAI_PORT_ATTR_INT_METADATA, |
Contributor
There was a problem hiding this comment.
The Locator metadata width depends on the tag type. How do we distinguish between Compact and Wide tags?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings SAI support for CSIG which is a UEC specification.