feat(ir): add OperationPtr.getOpOperands#956
Open
sueszli wants to merge 4 commits into
Open
Conversation
math-fehr
approved these changes
Jul 12, 2026
Contributor
Author
|
Thanks for reviewing. Makes sense, this is a lot cleaner. |
Collaborator
|
Sorry about the delay btw! |
Co-authored-by: Mathieu Fehr <mathieu.fehr@gmail.com>
Co-authored-by: Mathieu Fehr <mathieu.fehr@gmail.com>
sueszli
force-pushed
the
feat/op-getoperands
branch
from
31f714d to
10d3739
Compare
simp only [getOpOperand] unfolded the definition in the goal, leaving grind unable to close getOpOperands!.getElem!_eq_getOpOperand and getOpOperands!.getElem_eq_getOpOperand. Supplying getOpOperand as a grind parameter keeps it folded, so grind closes the goals by congruence after rewriting with Array.getElem_map/getElem_range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #663
Same structure as #955