[do not merge] inspecting llc's bejaviour with llvm.sext, llvm.zext and llvm.trunc#1981
Draft
luisacicolini wants to merge 4 commits into
Draft
[do not merge] inspecting llc's bejaviour with llvm.sext, llvm.zext and llvm.trunc#1981luisacicolini wants to merge 4 commits into
llc's bejaviour with llvm.sext, llvm.zext and llvm.trunc#1981luisacicolini wants to merge 4 commits into
Conversation
github-merge-queue Bot
pushed a commit
to opencompl/veir
that referenced
this pull request
Apr 10, 2026
We add the lowering patterns for `llvm.sext`, `llvm.zext`, `llvm.trunc` to behave like [`llc`](opencompl/lean-mlir#1981)
AlexanderViand
pushed a commit
to AlexanderViand/veir
that referenced
this pull request
Jun 29, 2026
We add the remaining correctness proofs for the isel patterns of sext/zext/trunc types for legal types within RV64 and update the tests accordingly. We also check the condition on the relation between the width of the input and output types (e.g., for sext, the return type's width must be greater than the operand's). Legal extensions are: i16 -> i64, i16 -> i32, i32 -> i64, while truncation is always legal (as described in the [legalizer](https://github.com/llvm/llvm-project/blob/16a0a1042f7e4e5a0c667096fcdeb5803e06d120/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp#L171-L179)). The patterns are based on the inspection of [llc](opencompl/lean-mlir#1981 behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remain a draft but I want to store somewhere the inspections of
llvm.sext,llvm.zextandllvm.trunc's instruction selection patterns.