Skip to content

ExpensesCollectionQuery: Add fromHost and revert direction#11586

Merged
gustavlrsn merged 1 commit intomainfrom
revert/expenses-direction
Mar 27, 2026
Merged

ExpensesCollectionQuery: Add fromHost and revert direction#11586
gustavlrsn merged 1 commit intomainfrom
revert/expenses-direction

Conversation

@gustavlrsn
Copy link
Copy Markdown
Member

@gustavlrsn gustavlrsn commented Mar 24, 2026

Project opencollective/opencollective#8607

Description

Reverting direction as it complicated some things, instead adding fromHost to enable the same thing.

Comment thread server/graphql/v2/interface/Account.ts
@gustavlrsn gustavlrsn force-pushed the revert/expenses-direction branch from 1d57791 to 903d115 Compare March 24, 2026 10:03
@gustavlrsn gustavlrsn marked this pull request as draft March 24, 2026 10:04
@gustavlrsn gustavlrsn force-pushed the revert/expenses-direction branch 3 times, most recently from c4c2a76 to 2366f9c Compare March 24, 2026 12:27
@gustavlrsn gustavlrsn marked this pull request as ready for review March 24, 2026 13:03
Comment thread server/graphql/v2/interface/Account.ts
Comment thread server/graphql/v2/query/collection/ExpensesCollectionQuery.ts
@gustavlrsn gustavlrsn force-pushed the revert/expenses-direction branch 3 times, most recently from 39dad59 to 1f9f23d Compare March 24, 2026 13:46
Comment thread server/graphql/v2/query/collection/ExpensesCollectionQuery.ts
@gustavlrsn gustavlrsn force-pushed the revert/expenses-direction branch from 91ecf9b to c1314f2 Compare March 25, 2026 11:06
@gustavlrsn gustavlrsn requested review from kewitz March 25, 2026 11:17
Copy link
Copy Markdown
Contributor

@kewitz kewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. It seems this will perfectly cover for the cases we have in the People dashboard.

@kewitz kewitz mentioned this pull request Mar 27, 2026
@gustavlrsn gustavlrsn merged commit ec630ba into main Mar 27, 2026
19 checks passed
@gustavlrsn gustavlrsn deleted the revert/expenses-direction branch March 27, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants