Skip to content

fix(host.ts): applies searchTerm to a vendor's legal name for admins#11558

Merged
Betree merged 2 commits intoopencollective:mainfrom
kfc35:8549_vendor_search_legal_name
Mar 31, 2026
Merged

fix(host.ts): applies searchTerm to a vendor's legal name for admins#11558
Betree merged 2 commits intoopencollective:mainfrom
kfc35:8549_vendor_search_legal_name

Conversation

@kfc35
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 commented Mar 20, 2026

Fixes opencollective/opencollective#8549

Edit: Sentry bot made me aware of what the original security note in the issue was referring to 😅 I have addressed it in the second commit.

Video of the fix in action (local api and local frontend running):

Screen.Recording.2026-03-20.at.12.17.44.AM.mov

Comment thread server/graphql/v2/object/Host.ts
@kfc35 kfc35 marked this pull request as draft March 20, 2026 04:55
@kfc35 kfc35 marked this pull request as ready for review March 20, 2026 05:48
@kfc35
Copy link
Copy Markdown
Contributor Author

kfc35 commented Mar 20, 2026

Unsure why the tests for server/controllers/legal-documents are failing — The code in this PR is unrelated, and I tried running the tests locally in my branch and those same tests succeed, so I can’t reproduce the failures. edit: rebasing onto main resolved this

I’m not sure why the GraphQL inspector is returning a Error: Resource not accessible by integration, but I suspect it is because my PR is coming from a fork. I’m going to assume that’s desired behavior unless y’all want to configure that github action to have write permissions for pull requests (which I understand might not be desired for security reasons).

Anyway, I’ve marked this as ready to review in spite of those two that ci failures.

@kfc35 kfc35 force-pushed the 8549_vendor_search_legal_name branch from 2f2824c to a106a31 Compare March 20, 2026 15:56
@kfc35 kfc35 force-pushed the 8549_vendor_search_legal_name branch from b909cb8 to 26b24a5 Compare March 22, 2026 04:36
@kfc35 kfc35 changed the title fix(host.ts): applies searchFilter to a vendor's legal name fix(host.ts): applies searchTerm to a vendor's legal name Mar 22, 2026
@kfc35 kfc35 force-pushed the 8549_vendor_search_legal_name branch from 26b24a5 to b7c5019 Compare March 22, 2026 04:37
@kfc35 kfc35 changed the title fix(host.ts): applies searchTerm to a vendor's legal name fix(host.ts): applies searchTerm to a vendor's legal name for admins Mar 22, 2026
@Betree Betree self-assigned this Mar 31, 2026
Copy link
Copy Markdown
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Betree
Copy link
Copy Markdown
Member

Betree commented Mar 31, 2026

Thansk @kfc35

@Betree Betree merged commit a5a2057 into opencollective:main Mar 31, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendors Cannot be Searched by Legal Name in Dashboard

2 participants