feat: save RUVNL data to data-platform and add test#187
Open
katyalmohit wants to merge 3 commits intomainfrom
Open
feat: save RUVNL data to data-platform and add test#187katyalmohit wants to merge 3 commits intomainfrom
katyalmohit wants to merge 3 commits intomainfrom
Conversation
| be_flanders,51.00,4.46,,Flanders,be,STATE | ||
| be_wallonia,50.50,4.70,,Wallonia,be,STATE | ||
| be_brussels,50.85,4.35,,Brussels,be,STATE | ||
| ruvnl_solar_site,26.4499,74.65,1,,ind_rajasthan,STATE |
Contributor
There was a problem hiding this comment.
i wonder if you can now call it ruvnl_solar, so you can drop the site
Contributor
Author
There was a problem hiding this comment.
I checked the locations on the dev data-platform of India. These are named ruvnl_solar_site and ruvnl_wind_site only
Contributor
There was a problem hiding this comment.
To be honest, you can now name them both just ruvnl, as wind and solar are are in the energy type. Hmm i wonder how they got it there? Maybe in the site-forecast-app
peterdudfield
requested changes
Apr 8, 2026
Contributor
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
Looks good, theres a few small suggested changes
Contributor
|
And have you run it with the dev platform in India? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Added support to save RUVNL generation data to data-platform
Fixes #176
How Has This Been Tested?
Checklist: