Skip to content

add global state isPlaying for PlayButton#710

Merged
braddf merged 5 commits intodevelopmentfrom
feat/play-pause-button
Apr 16, 2026
Merged

add global state isPlaying for PlayButton#710
braddf merged 5 commits intodevelopmentfrom
feat/play-pause-button

Conversation

@suvanbanerjee
Copy link
Copy Markdown
Contributor

@suvanbanerjee suvanbanerjee commented Mar 31, 2026

Pull Request

Description

added global state for playing
added the play button in all tabs
added useEffect to pause playback and reset time to Now

Screencast.From.2026-04-01.12-18-38.mp4

Fixes #448

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@suvanbanerjee suvanbanerjee requested a review from braddf March 31, 2026 08:57
@suvanbanerjee suvanbanerjee self-assigned this Mar 31, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nowcasting-app Ready Ready Preview, Comment Apr 14, 2026 5:01am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
quartz-app Ignored Ignored Preview Apr 14, 2026 5:01am

Request Review

Comment thread apps/nowcasting-app/components/play-button/index.tsx
Comment thread apps/nowcasting-app/components/charts/solar-site-view/solar-site-chart.tsx Outdated
@braddf braddf merged commit 68d3835 into development Apr 16, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants