feat[map]: add reset button for map state modifications#695
feat[map]: add reset button for map state modifications#695suvanbanerjee merged 3 commits intodevelopmentfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
braddf
left a comment
braddf
left a comment
There was a problem hiding this comment.
Couple of comments, otherwise looks good!
| return `<svg fill="#000000" viewBox="0 0 1920 1920" xmlns="http://www.w3.org/2000/svg"> | ||
| <g id="SVGRepo_bgCarrier" stroke-width="0"></g> | ||
| <g id="SVGRepo_tracerCarrier" stroke-linecap="round" stroke-linejoin="round"></g> | ||
| <g id="SVGRepo_iconCarrier"> | ||
| <path d="M960 0v213.333c411.627 0 746.667 334.934 746.667 746.667S1371.627 1706.667 960 1706.667 213.333 1371.733 213.333 960c0-197.013 78.4-382.507 213.334-520.747v254.08H640V106.667H53.333V320h191.04C88.64 494.08 0 720.96 0 960c0 529.28 430.613 960 960 960s960-430.72 960-960S1489.387 0 960 0" fill-rule="evenodd"> | ||
| </path> | ||
| </g> | ||
| </svg>`; | ||
| }; |
There was a problem hiding this comment.
@braddf It is a string because we have to use it in html format, not sure if i should put it here or directly put it in
https://github.com/openclimatefix/quartz-frontend/pull/695/changes#diff-7251d9455f72e8fb43a93e7db2375b1429df6904295216039ede6b9da8fa5fe2R134
There was a problem hiding this comment.
This is always an awkward thing going into forced HTML string behaviours... this is okay for now 👍
braddf
left a comment
braddf
left a comment
There was a problem hiding this comment.
Nice, so am I correct that this disables tilt on the map? Not sure if there's any WebGL / performance improvement from disabling 3D map behaviour, but wouldn't that be ideal if it did... 😁
2 participants
Pull Request
Description
Reset button added on top of the zoom controls on bottom right of map
this will only appear if maps is not in default state
Fixes #183
Checklist: