Skip to content

fixes for tests#280

Closed
peterdudfield wants to merge 13 commits intodevsjc/python-grpcfrom
pd/python-grpc
Closed

fixes for tests#280
peterdudfield wants to merge 13 commits intodevsjc/python-grpcfrom
pd/python-grpc

Conversation

@peterdudfield
Copy link
Copy Markdown
Contributor

@peterdudfield peterdudfield commented Apr 8, 2026

Pull Request

Description

  • fix for test 4.4
  • remove gsp_id_map.clear from loop
  • fix for only include pvlive/all data if has values in it
    Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title fir for test 4.4 fixes for tests Apr 8, 2026
@devsjc devsjc force-pushed the devsjc/python-grpc branch 2 times, most recently from cade8a5 to ce346a9 Compare April 9, 2026 09:23
@devsjc
Copy link
Copy Markdown
Contributor

devsjc commented Apr 9, 2026

Thanks for this Peter! Good spot on the map clearing. Instead of solving all the merge conflicts, I've just taken the changes you made and added them directly into the original branch.

@devsjc devsjc closed this Apr 9, 2026
@peterdudfield
Copy link
Copy Markdown
Contributor Author

All good, i checked in the PR but perhaps couldnt see the fixes. Ill let you double check to see if they went in. This comment is just to help you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants