Skip to content

feat(output): add --suppress-reads flag#193

Merged
osolmaz merged 2 commits intomainfrom
codex/land-pr-136
Mar 29, 2026
Merged

feat(output): add --suppress-reads flag#193
osolmaz merged 2 commits intomainfrom
codex/land-pr-136

Conversation

@osolmaz
Copy link
Copy Markdown
Contributor

@osolmaz osolmaz commented Mar 29, 2026

Supersedes #136 to land the same change from an origin-hosted branch after the contributor fork branch stopped reporting checks reliably after maintainer updates.

This replacement keeps the contributor's feature commit, adds the required changelog entry, and preserves credit to @hayatosc.

Original contribution:

Behavior is unchanged relative to the contributor branch: this still adds --suppress-reads so text and JSON output can mask raw file-read bodies while leaving normal tool activity visible.

Follow-up after merge:

@osolmaz osolmaz merged commit fe3728b into main Mar 29, 2026
8 checks passed
@osolmaz osolmaz deleted the codex/land-pr-136 branch March 29, 2026 09:40
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6daad2bf7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


export function isReadLikeTool(tool: ReadLikeToolDescriptor): boolean {
return (
tool.kind?.trim().toLowerCase() === "read" || inferToolKindFromTitle(tool.title) === "read"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prefer explicit non-read kind over title inference

isReadLikeTool currently treats a tool as read-like whenever the title contains read-ish substrings, even if kind is explicitly set to a non-read value. With --suppress-reads, this causes non-read tools to have their output masked (e.g., { kind: "edit", title: "Edit README.md" } matches read in the title and gets suppressed), which hides normal tool activity unexpectedly in both text and JSON output. The explicit kind should take precedence over heuristic title matching.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants